Skip empty run rates #222
Merged
Skip empty run rates #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
force-pushed
the
skip_empty
branch
from
8f55f12 to
f4044b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #222 +/- ##
==========================================
+ Coverage 77.83% 77.90% +0.06%
==========================================
Files 54 54
Lines 4724 4738 +14
==========================================
+ Hits 3677 3691 +14
Misses 1047 1047 ☔ View full report in Codecov by Sentry. |
peterfpeterson
force-pushed
the
skip_empty
branch
4 times, most recently
from
bc6090e to
8f1caf8
Compare
peterfpeterson
force-pushed
the
skip_empty
branch
from
8f1caf8 to
5fe229f
Compare
backmari
approved these changes
Mar 4, 2025
Contributor
backmari
left a comment
backmari
left a comment
There was a problem hiding this comment.
The changes should improve performance by skipping collecting histogram data for runs per hour if there are no runs/errors in the last 24 hours.
I have tested locally that the runs per hour plots work both for instruments with and without runs and errors in the last 24 hours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This verifies that there are any runs during the requested time period before running the stored procedure call and/or the hand written version. This should have an immediate effect of speeding up instruments that aren't measuring data (e.g. NOW*) and make the extended dashboard faster.
DO NOT MERGE BEFORE #219
Check all that apply:
References:
Manual test for the reviewer
(Instructions for testing here)
Check list for the reviewer